Re: [RFC v2 07/13] power: pwrseq: simple: Add support for toggling regulator
From: Javier Martinez Canillas <hidden>
Date: 2016-05-05 19:31:18
Also in:
linux-arm-kernel, linux-mmc, linux-pm, linux-samsung-soc, lkml
Hello Krzysztof, On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote:
Some devices need real hard-reset by cutting the power. During power sequence turn off and on the regulator, if it is provided. Signed-off-by: Krzysztof Kozlowski <redacted> ---
[snip]
quoted hunk ↗ jump to hunk
#define to_pwrseq_simple(p) container_of(p, struct mmc_pwrseq_simple, pwrseq)@@ -62,6 +65,13 @@ static void mmc_pwrseq_simple_post_power_on(struct pwrseq *_pwrseq) { struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(_pwrseq); + if (pwrseq->ext_reg) { + int err; + + err = regulator_enable(pwrseq->ext_reg); + WARN_ON_ONCE(err); + } +
Shouldn't this be in mmc_pwrseq_simple_pre_power_on() instead? For example, a chip may need to be powered on before attempting to toggle its reset or power pins using some GPIO lines. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America