Thread (16 messages) 16 messages, 4 authors, 2015-12-15

Re: [PATCH 4/8 v4] thermal: rcar: retern error rcar_thermal_get_temp() if no ctemp update

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2015-12-15 00:24:53
Also in: linux-pm, linux-sh, lkml

Hi Eduardo, again
I believe the problem here is actually the lack of error
handling/propagation. Are you sure you want to write to parameter
in the fail path ?

rcar_thermal_update_temp already returns error code when it fails
to read temperature. Don't you think it would make more sense to fix the
places that call rcar_thermal_update_temp to properly handle its return
value and propagate that error code when necessary?
Will update in v5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help