Re: [PATCH 8/8 v4] thermal: of-thermal: of_thermal_set_trip_temp() call thermal_zone_device_update()
From: Eduardo Valentin <edubezval@gmail.com>
Date: 2015-12-14 21:11:18
Also in:
linux-pm, linux-sh, lkml
Hey! On Tue, Dec 08, 2015 at 05:30:00AM +0000, Kuninori Morimoto wrote:
quoted hunk ↗ jump to hunk
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> of_thermal_set_trip_temp() updates trip temperature. It should call thermal_zone_device_update() immediately. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- v3 -> v4 - no change drivers/thermal/of-thermal.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index 42b7d42..a1dd7b1 100644 --- a/drivers/thermal/of-thermal.c +++ b/drivers/thermal/of-thermal.c@@ -334,6 +334,8 @@ static int of_thermal_set_trip_temp(struct thermal_zone_device *tz, int trip, /* thermal framework should take care of data->mask & (1 << trip) */ data->trips[trip].temperature = temp; + thermal_zone_device_update(tz); +
Although I understand the need for this, I would prefer you move this change to thermal_core.c. The reasoning is to keep the same behavior for thermal zones created over of thermal and regular thermal zones. BR,
return 0; } -- 1.9.1