Re: [PATCH 4/8 v4] thermal: rcar: retern error rcar_thermal_get_temp() if no ctemp update
From: Eduardo Valentin <edubezval@gmail.com>
Date: 2015-12-14 21:20:28
Also in:
linux-pm, linux-sh, lkml
On Tue, Dec 08, 2015 at 05:28:13AM +0000, Kuninori Morimoto wrote:
quoted hunk ↗ jump to hunk
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Current rcar_thermal_get_temp() returns latest temperature, but it might not be updated if some HW issue happened. This means user might get wrong temperature. This patch solved this issue. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- v3 -> v4 - "happend" -> "happened" drivers/thermal/rcar_thermal.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 67b5216..40c3ba5 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c@@ -199,9 +199,9 @@ static int rcar_thermal_update_temp(struct rcar_thermal_priv *priv) dev_dbg(dev, "thermal%d %d -> %d\n", priv->id, priv->ctemp, ctemp); - priv->ctemp = ctemp; ret = 0; err_out_unlock: + priv->ctemp = ctemp; mutex_unlock(&priv->lock); return ret;
I believe the problem here is actually the lack of error handling/propagation. Are you sure you want to write to parameter in the fail path ? rcar_thermal_update_temp already returns error code when it fails to read temperature. Don't you think it would make more sense to fix the places that call rcar_thermal_update_temp to properly handle its return value and propagate that error code when necessary? BR,