Hi Sergei,

On 11/21/2015 8:19 AM, Sergei Shtylyov wrote:

Hello.

On 11/21/2015 3:17 AM, Joshua Henderson wrote:

quoted

From: Andrei Pistirica <redacted>

Document the devicetree bindings for the SDHC peripheral found on
Microchip PIC32 class devices.

Signed-off-by: Andrei Pistirica <redacted>
Signed-off-by: Joshua Henderson <redacted>
---
  .../devicetree/bindings/mmc/sdhci-pic32.txt        |   24 ++++++++++++++++++++
  1 file changed, 24 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pic32.txt

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt
new file mode 100644
index 0000000..f16388c
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-pic32.txt

@@ -0,0 +1,24 @@
+* Microchip PIC32 SDHCI Controller
+
+This file documents differences between the core properties in mmc.txt
+and the properties used by the sdhci-pic32 driver.
+
+Required properties:
+- compatible: Should be "microchip,pic32-sdhci"
+- reg: Should contain registers location and length
+- interrupts: Should contain interrupt
+- pinctrl: Should contain pinctrl for data and command lines

   This is a required prop, yet the example doesn't contain it?

Ack.  Both the required properties and example need to contain pinctrl-names and pinctrl-0, not pinctrl.

quoted

+
+Optional properties:
+- no-1-8-v: 1.8V voltage selection not supported
+- piomode: disable DMA support
+
+Example:
+
+    sdhci@1f8ec000 {
+        compatible = "microchip,pic32-sdhci";
+        reg = <0x1f8ec000 0x100>;
+        interrupts = <SDHC_EVENT DEFAULT_INT_PRI IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&REFCLKO4>, <&PBCLK5>;
+        clock-names = "base_clk", "sys_clk";

   The "clocks" and "clock-names" props are not documented.

[...]

MBR, Sergei

Ack.

Thanks for the feedback,
Josh