Hi Arnd,

On 11/21/2015 1:49 PM, Arnd Bergmann wrote:

On Friday 20 November 2015 17:17:15 Joshua Henderson wrote:

quoted

+/* PIC32 specific clks */
+pic32_clktree {
+       #address-cells = <1>;
+       #size-cells = <1>;
+       reg = <0x1f801200 0x200>;
+       compatible = "microchip,pic32-clk";
+       interrupts = <12>;
+       ranges;
+
+       /* secondary oscillator; external input on SOSCI pin */
+       SOSC:sosc_clk {
+               #clock-cells = <0>;
+               compatible = "microchip,pic32-sosc";
+               clock-frequency = <32768>;
+               reg = <0x1f801200 0x10   /* enable reg */
+                       0x1f801390 0x10>; /* status reg */
+               microchip,bit-mask = <0x02>; /* enable mask */
+               microchip,status-bit-mask = <0x10>; /* status-mask*/
+       };

If you want to use the reg property in this way for each cell,
at least use a 'ranges' that only translates the actual registers
like this

	ranges = <0 0x1f801200 0x200>

	sosc_clk {
		...
		reg = <0x000 0x10>, <0x190 0x10>;
		...
	};

	Arnd

This does indeed seem to be the correct way to use ranges in this case.  Consider it done.

Thanks for the feedback,
Josh