On Wed, Sep 16, 2015 at 03:31:06PM +0900, Krzysztof Kozlowski wrote:

On 16.09.2015 02:58, Andreas Dannenberg wrote:

quoted

This patch allows reading (and writing, if the D+/D- USB signal-based
charger type detection is disabled) of the input current limit through
the POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT sysfs property. This allows
userspace to see what charger was detected and to re-configure the
maximum current drawn from the external supply at runtime based on
system-level knowledge or user input.

Signed-off-by: Andreas Dannenberg <redacted>
---
 drivers/power/bq24257_charger.c | 67 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

Reviewed-by: Krzysztof Kozlowski <redacted>

BTW you are exposing more and more sysfs attributes which are userspace
interfaces. They should be documented:
Documentation/SubmitChecklist - point 19
Documentation/ABI/README

The patch comment is not 100% accurate. I'm not declaring/exposing a new
sysfs property but rather use the power supply framework to expose the
sysfs property that's associated with POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT
which is actually called "input_current_limit". Will reword the description
to make this clearer.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc

Although not all new drivers (and perhaps not all reviewers) follow this
rule...

Best regards,
Krzysztof