Thread (26 messages) 26 messages, 2 authors, 2015-09-18

Re: [PATCH v4 08/10] power: bq24257: Allow input current limit sysfs access

From: Krzysztof Kozlowski <hidden>
Date: 2015-09-16 06:31:06
Also in: linux-pm

On 16.09.2015 02:58, Andreas Dannenberg wrote:
This patch allows reading (and writing, if the D+/D- USB signal-based
charger type detection is disabled) of the input current limit through
the POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT sysfs property. This allows
userspace to see what charger was detected and to re-configure the
maximum current drawn from the external supply at runtime based on
system-level knowledge or user input.

Signed-off-by: Andreas Dannenberg <redacted>
---
 drivers/power/bq24257_charger.c | 67 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)
Reviewed-by: Krzysztof Kozlowski <redacted>

BTW you are exposing more and more sysfs attributes which are userspace
interfaces. They should be documented:
Documentation/SubmitChecklist - point 19
Documentation/ABI/README

Although not all new drivers (and perhaps not all reviewers) follow this
rule...

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help