Re: [PATCH 2/3] TTY: add support for tty_slave devices.
From: Paul Bolle <hidden>
Date: 2015-03-18 09:11:43
Also in:
lkml
Just two nits to look into once you get to fix up all the smaller issues. NeilBrown schreef op wo 18-03-2015 om 16:58 [+1100]:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/tty/slave/Kconfig@@ -0,0 +1,7 @@ +menuconfig TTY_SLAVE + tristate "TTY slave devices" + depends on OF + help + Devices which attach via a uart, but need extra + driver support for power management etc. +
This blank line makes "git am" whine: "new blank line at EOF".
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/tty/slave/tty_slave_core.c
[...] This file doesn't have a MODULE_LICENSE() macro. So I think that, if this driver is built as a module and loaded, kernel/module.c will set its license to "unspecified" and taint the kernel. Paul Bolle