Hi Mark,

On 27 August 2014 16:39, Mark Rutland [off-list ref] wrote:

Hi,

On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote:

quoted

From: Alim Akhtar <alim.akhtar@samsung.com>

This patch adds the necessary Kconfig entries to enable
support for the ARMv8 based Exynos7 SoC.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Naveen Krishna Chatradhi <redacted>
Cc: Rob Herring <robh@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
---
 arch/arm64/Kconfig |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index fd4e81a..d555558 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig

@@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer"

 menu "Platform selection"

+config ARCH_EXYNOS7
+     bool "ARMv8 based SAMSUNG EXYNOS7"
+     select HAVE_S3C2410_WATCHDOG if WATCHDOG
+     select CLKSRC_OF

This seems to be implied by ARM_ARCH_TIMER in the core arm64 Kconfig, so
I'm not sure this is necessary.

Ok.

quoted

+     select COMMON_CLK_SAMSUNG
+     select GPIOLIB

You select ARCH_REQUIRE_GPIOLIB below, so is this necessary?

Yes, this is not required. Will remove.

quoted

+     select PINCTRL
+     select PINCTRL_EXYNOS
+     select RTC_CLASS
+     select HAVE_S3C_RTC
+     select GENERIC_GPIO
+     select ARCH_REQUIRE_GPIOLIB
+     select HAVE_CLK

Isn't this selected already through the core arm64 Kconfig?

It looks like we have COMMON_CLK, which selects CLKDEV_LOOKUP, which
selects HAVE_CLK.

Ok.

quoted

+     select HAVE_SMP

I may have missed something, but I didn't see any SMP support in this
series.

As Catalin suggested, will remove this.

Thanks,
Mark.

Thanks for your comments.

-- 
Shine bright,
(: Nav :)