Hello Tomasz,

On 27 August 2014 16:44, Tomasz Figa [off-list ref] wrote:

Hi Naveen,

Please see my comments inline.

On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote:

quoted

Add the required pin configuration support to EXYNOS7

[snip]

quoted

+/ {
+     /* ALIVE block @10580000 */
+     pinctrl@10580000 {

This syntax repeating the whole hierarchy of nodes in every dts file is
considered obsolete in case of Exynos DT sources. Please switch to
reference-based one. Please see related files for Exynos5260 and 5800 as
examples.

Sure, will respin with reference based usage.

[snip]

quoted

+             disp_teson: disp_teson {
+                     samsung,pins = "gpg0-1";
+                     samsung,pin-function = <2>;
+             };
+
+             disp_tesoff: disp_tesoff {
+                     samsung,pins = "gpg0-1";
+                     samsung,pin-function = <0>;

This is not a special function, so I don't think it belongs to this file.

Best regards,
Tomasz

Thanks for the in depth review.
Will fixes the comments.


-- 
Thanks & Regards,
(: Nav :)