Thread (40 messages) 40 messages, 12 authors, 2014-09-14

Re: [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7

From: Tomasz Figa <hidden>
Date: 2014-08-27 11:14:06
Also in: linux-arm-kernel, linux-samsung-soc

Hi Naveen,

Please see my comments inline.

On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote:
Add the required pin configuration support to EXYNOS7
[snip]
+/ {
+	/* ALIVE block @10580000 */
+	pinctrl@10580000 {
This syntax repeating the whole hierarchy of nodes in every dts file is
considered obsolete in case of Exynos DT sources. Please switch to
reference-based one. Please see related files for Exynos5260 and 5800 as
examples.

[snip]
+		disp_teson: disp_teson {
+			samsung,pins = "gpg0-1";
+			samsung,pin-function = <2>;
+		};
+
+		disp_tesoff: disp_tesoff {
+			samsung,pins = "gpg0-1";
+			samsung,pin-function = <0>;
This is not a special function, so I don't think it belongs to this file.

Best regards,
Tomasz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help