Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2014-02-11 16:37:26
Also in:
linux-media, lkml
Am Dienstag, den 11.02.2014, 16:23 +0100 schrieb Laurent Pinchart:
Hi Russell, On Tuesday 11 February 2014 14:52:48 Russell King - ARM Linux wrote:quoted
On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote:quoted
On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote:quoted
This allows to reuse the same parser code from outside the V4L2 framework, most importantly from display drivers. There have been patches that duplicate the code (and I am going to send one of my own), such as http://lists.freedesktop.org/archives/dri-devel/2013-August/043308.html and others that parse the same binding in a different way: https://www.mail-archive.com/linux-omap@vger.kernel.org/msg100761.html I think that all common video interface parsing helpers should be moved to a single place, outside of the specific subsystems, so that it can be reused by all drivers.Perhaps that should be done rather than moving to drivers/of now and then again to somewhere else.Do you have a better suggestion where it should move to? drivers/gpu/drm - no, because v4l2 wants to use it drivers/media/video - no, because DRM drivers want to use it drivers/video - no, because v4l2 and drm drivers want to use itJust pointing out a missing location (which might be rejected due to similar concerns), there's also drivers/media, which isn't V4L-specific.
Since drivers/Makefile has media/ in obj-y, moving the graph helpers to drivers/media should technically work.
quoted
Maybe drivers/of-graph/ ? Or maybe it's just as good a place to move it into drivers/of ?
include/media/of_graph.h, drivers/media/of_graph.c? regards Philipp