Thread (74 messages) 74 messages, 13 authors, 2014-03-21

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

From: Rob Herring <hidden>
Date: 2014-02-11 16:31:02
Also in: linux-media, lkml

On Tue, Feb 11, 2014 at 8:52 AM, Russell King - ARM Linux
[off-list ref] wrote:
On Tue, Feb 11, 2014 at 07:56:33AM -0600, Rob Herring wrote:
quoted
On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel [off-list ref] wrote:
quoted
This allows to reuse the same parser code from outside the V4L2 framework,
most importantly from display drivers. There have been patches that duplicate
the code (and I am going to send one of my own), such as
http://lists.freedesktop.org/archives/dri-devel/2013-August/043308.html
and others that parse the same binding in a different way:
https://www.mail-archive.com/linux-omap@vger.kernel.org/msg100761.html

I think that all common video interface parsing helpers should be moved to a
single place, outside of the specific subsystems, so that it can be reused
by all drivers.
Perhaps that should be done rather than moving to drivers/of now and
then again to somewhere else.
Do you have a better suggestion where it should move to?
No.
drivers/gpu/drm - no, because v4l2 wants to use it
drivers/media/video - no, because DRM drivers want to use it
drivers/video - no, because v4l2 and drm drivers want to use it
I don't believe it exists currently, so it would need to be created.
Perhaps adding a layer of directory to combine these. This patch alone
is not enough to really justify that, but if there's a lot more shared
code possible then it would be the right direction.
Maybe drivers/of-graph/ ?  Or maybe it's just as good a place to move it
into drivers/of ?
I assume you weren't serious, but no for /of-graph. If a better place
can't be found/made, I'll take it.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help