Re: [PATCH 3/4] pinctrl: remove slew-rate parameter from tz1090

On 25/06/13 14:32, Linus Walleij wrote:

On Tue, Jun 25, 2013 at 3:27 PM, James Hogan [off-list ref] wrote:

quoted

On 25/06/13 14:21, Heiko Stübner wrote:

quoted

quoted

My thoughts were that this code would never be reached when the parsing was
removed and to not cause confusion to the driver when an acceptable binding
was found for slew-rate.

But it of course also doesn't hurt to stay in.

Okay, fair enough.

Acked-by: James Hogan <redacted>

OK applied this so we have a clean slate.

Patches adding it back in with SI measures will be welcomed!

Okay.

So the most descriptive documentation I can find for the slew rate in
the TZ1090 pin config hardware is basically:

0: slow (half frequency)
1: fast

Sounds like this pretty much precludes it from having a generic DT
binding unless it can be mapped to some physical value, so I'll add a
tz1090,slew-rate and use PIN_CONFIG_END+1 instead of PIN_CONFIG_SLEW_RATE.

Anybody object to me adding an argument to
pinconf_generic_parse_dt_config() so that an additional
pinconf_generic_dt_params array can be optionally passed in? That way I
can share the generic pinconf dt parsing code.

Cheers
James