Thread (35 messages) 35 messages, 2 authors, 2012-11-23

Re: [PATCH v4 01/11] PWMSS: Add PWM Subsystem driver for parent<->child relationship

From: Thierry Reding <hidden>
Date: 2012-11-22 20:47:28
Also in: linux-arm-kernel, linux-omap, lkml

On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote:
[...]
+static const struct of_device_id pwmss_of_match[] = {
+	{
+		.compatible	= "ti,am33xx-pwmss",
+	},
For consistency with other drivers this should be all on one line.
+static const struct dev_pm_ops pwmss_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(pwmss_suspend, pwmss_resume)
+};
This could be even shorter:

static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);

Thierry

Attachments

  • (unnamed) [application/pgp-signature] 836 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help