On Fri, Nov 23, 2012 at 02:17:04, Thierry Reding wrote:

On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote:
[...]

quoted

+static const struct of_device_id pwmss_of_match[] = {
+	{
+		.compatible	= "ti,am33xx-pwmss",
+	},

For consistency with other drivers this should be all on one line.

Ok I will correct it.

quoted

+static const struct dev_pm_ops pwmss_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(pwmss_suspend, pwmss_resume)
+};

This could be even shorter:

static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);

Ok I will correct it.

Thanks
Avinash

Thierry