On Wed, Nov 21, 2012 at 06:40:58PM +0530, Philip, Avinash wrote:
[...]

+static const struct of_device_id pwmss_of_match[] = {
+	{
+		.compatible	= "ti,am33xx-pwmss",
+	},

For consistency with other drivers this should be all on one line.

+static const struct dev_pm_ops pwmss_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(pwmss_suspend, pwmss_resume)
+};

This could be even shorter:

static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121122/3bb858fb/attachment.sig>