Re: [PATCH] x86/crypto: Add missing RETs

ne 1. 7. 2018 o 15:20 Herbert Xu [off-list ref] napísal(a):

On Sat, Jun 23, 2018 at 12:36:22PM +0200, Borislav Petkov wrote:

quoted

Lemme send a proper patch now...

---
From: Borislav Petkov <redacted>
Date: Sun, 17 Jun 2018 13:57:42 +0200
Subject: [PATCH] x86/crypto: Add missing RETs

Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
otherwise they run into INT3 padding due to

  51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")

leading to spurious debug exceptions.

Mike Galbraith [off-list ref] took care of all the remaining callsites.

Signed-off-by: Borislav Petkov <redacted>

Patch applied.  Thanks.

Hi Herbert,

I can see you applied this patch to your cryptodev-2.6 tree (which I
believe is for the next release). Shouldn't this go into the
crypto-2.6 tree so it gets into 4.18-rcX? I'm not sure, but it seems
to me that it qualifies as a (potentially serious?) bug fix.

Also, I think you accidentally extracted the wrong part of the e-mail
as the commit message...

Thanks,

Ondrej