Thread (16 messages) 16 messages, 7 authors, 2018-07-06

Re: [PATCH] x86/crypto: Add missing RETs

From: Ingo Molnar <mingo@kernel.org>
Date: 2018-06-24 07:11:17
Also in: lkml

* Borislav Petkov [off-list ref] wrote:
Lemme send a proper patch now...

---
From: Borislav Petkov <redacted>
Date: Sun, 17 Jun 2018 13:57:42 +0200
Subject: [PATCH] x86/crypto: Add missing RETs

Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
otherwise they run into INT3 padding due to

  51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")

leading to spurious debug exceptions.

Mike Galbraith [off-list ref] took care of all the remaining callsites.
Note that 51bad67ffbce has been zapped because it caused too many problems like 
this, but the explicit RETs make sense nevertheless. When applying the patch 
please don't include the SHA1 of the non-upstream (and probably never-upstream) 
commit.

Thanks,

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help