Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
From: Tim Chen <hidden>
Date: 2016-07-08 17:18:07
Also in:
kernel-janitors, lkml
On Sat, 2016-07-09 at 00:45 +0800, Herbert Xu wrote:
On Fri, Jul 08, 2016 at 09:28:03AM -0700, Tim Chen wrote:quoted
Sorry I was on vacation and didn't get to respond earlier. Let's switch the above from | to || so the code logic is clearer. Also clean up various multi-line comment style inconsistencies in patch below.Nack. As I said the commenting style in the crypto API is the same as the network stack. So unless we decide to change both please stick to the current style.
Will you like a patch with just the | to || change, or leave the code as is? Tim