Re: [patch] crypto: sha256-mb - cleanup a || vs | typo
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2016-07-08 16:45:54
Also in:
kernel-janitors, lkml
On Fri, Jul 08, 2016 at 09:28:03AM -0700, Tim Chen wrote:
Sorry I was on vacation and didn't get to respond earlier. Let's switch the above from | to || so the code logic is clearer. Also clean up various multi-line comment style inconsistencies in patch below.
Nack. As I said the commenting style in the crypto API is the same as the network stack. So unless we decide to change both please stick to the current style. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt