Thread (183 messages) 183 messages, 11 authors, 2022-01-29

Re: [PATCH v8 22/40] x86/sev: move MSR-based VMGEXITs for CPUID to helper

From: Borislav Petkov <bp@alien8.de>
Date: 2022-01-04 20:57:07
Also in: kvm, linux-efi, linux-mm, lkml, platform-driver-x86

On Thu, Dec 30, 2021 at 06:52:52PM +0000, Sean Christopherson wrote:
Having @subfunc, a.k.a. index, in is weird/confusing/fragile because it's not consumed,
nor is it checked.  Peeking ahead, it looks like all future users pass '0'.  Taking the
index but dropping it on the floor is asking for future breakage.  Either drop it or
assert that it's zero.
Yah, just drop it please. 

It can always be added later if needed.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help