Re: [PATCH v5 1/7] can: netlink: allow user to turn off unsupported features

[PATCH v5 0/7] add the netlink interface for CAN-FD Transmitter Delay Compensation (TDC) · Vincent Mailhol <hidden> · 2021-08-15
[PATCH v5 1/7] can: netlink: allow user to turn off unsupported features · Vincent Mailhol <hidden> · 2021-08-15
Re: [PATCH v5 1/7] can: netlink: allow user to turn off unsupported features · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-19
Re: [PATCH v5 1/7] can: netlink: allow user to turn off unsupported features · Vincent MAILHOL <hidden> · 2021-08-19
Re: [PATCH v5 1/7] can: netlink: allow user to turn off unsupported features · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-19
[PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent Mailhol <hidden> · 2021-08-15
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-17
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-17
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-18
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-18
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-18
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-20
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-17
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Stefan Mätje <Stefan.Maetje@esd.eu> · 2021-08-16
Re: [PATCH v5 2/7] can: bittiming: allow TDC{V,O} to be zero and add can_tdc_const::tdc{v,o,f}_min · Vincent MAILHOL <hidden> · 2021-08-16
[PATCH v5 3/7] can: bittiming: change unit of TDC parameters to clock periods · Vincent Mailhol <hidden> · 2021-08-15
[PATCH v5 4/7] can: dev: add can_tdc_get_relative_tdco() helper function · Vincent Mailhol <hidden> · 2021-08-15
Re: [PATCH v5 4/7] can: dev: add can_tdc_get_relative_tdco() helper function · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-16
[PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Vincent Mailhol <hidden> · 2021-08-15
Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-17
Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Vincent MAILHOL <hidden> · 2021-08-18
Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-18
Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Vincent MAILHOL <hidden> · 2021-08-18
Re: [PATCH v5 5/7] can: netlink: add interface for CAN-FD Transmitter Delay Compensation (TDC) · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-18
[PATCH v5 6/7] can: netlink: add can_priv::do_get_auto_tdcv() to retrieve tdcv from device · Vincent Mailhol <hidden> · 2021-08-15
[PATCH v5 7/7] can: etas_es58x: clean-up documentation of struct es58x_fd_tx_conf_msg · Vincent Mailhol <hidden> · 2021-08-15
Re: [PATCH v5 7/7] can: etas_es58x: clean-up documentation of struct es58x_fd_tx_conf_msg · Marc Kleine-Budde <mkl@pengutronix.de> · 2021-08-19

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2021-08-19 07:45:27
Also in: lkml, netdev

On 15.08.2021 12:32:42, Vincent Mailhol wrote:

The sanity checks on the control modes will reject any request related
to an unsupported features, even turning it off.

Example on an interface which does not support CAN-FD:

$ ip link set can0 type can bitrate 500000 fd off
RTNETLINK answers: Operation not supported

This patch lets such command go through (but requests to turn on an
unsupported feature are, of course, still denied).

Signed-off-by: Vincent Mailhol <redacted>

I'm planing to send a pull request to net-next today. I want to do some
more tests with this series, but this patch is more or less unrelated,
so I can take it in this PR, should I?

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachments

signature.asc [application/pgp-signature] 488 bytes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help