Thread (98 messages) 98 messages, 9 authors, 2015-01-26

Re: [PATCH v6 5/7] can: kvaser_usb: Update interface state before exiting on OOM

From: Andri Yngvason <hidden>
Date: 2015-01-26 10:53:06
Also in: lkml, netdev

Quoting Marc Kleine-Budde (2015-01-26 10:50:12)
On 01/26/2015 11:28 AM, Andri Yngvason wrote:
quoted
Quoting Ahmed S. Darwish (2015-01-26 05:27:19)
quoted
From: Ahmed S. Darwish <redacted>

Update all of the can interface's state and error counters before
trying any skb allocation that can actually fail with -ENOMEM.

Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Ahmed S. Darwish <redacted>
---
 drivers/net/can/usb/kvaser_usb.c |  181 ++++++++++++++++++++++----------------
 1 files changed, 105 insertions(+), 76 deletions(-)
[..]
quoted
Looks good to me.
Can I add your Acked-by to 5-7?
Yes.

--
Andri
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help