Re: [PATCH v5 4/5] can: kvaser_usb: Retry the first bulk transfer on -ETIMEDOUT

On Wed, Jan 21, 2015 at 03:24:46PM +0300, Sergei Shtylyov wrote:

Hello.

On 1/21/2015 12:48 AM, Ahmed S. Darwish wrote:

quoted

From: Ahmed S. Darwish <redacted>

quoted

On some x86 laptops, plugging a Kvaser device again after an
unplug makes the firmware always ignore the very first command.
For such a case, provide some room for retries instead of
completly exiting the driver init code.

   Completely.

quoted

Signed-off-by: Ahmed S. Darwish <redacted>
---
 drivers/net/can/usb/kvaser_usb.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

quoted

diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
index 640b0eb..068e76c 100644
--- a/drivers/net/can/usb/kvaser_usb.c
+++ b/drivers/net/can/usb/kvaser_usb.c

[...]

quoted

@@ -1632,7 +1632,15 @@ static int kvaser_usb_probe(struct usb_interface *intf,

 	usb_set_intfdata(intf, dev);

-	err = kvaser_usb_get_software_info(dev);
+	/* On some x86 laptops, plugging a Kvaser device again after
+	 * an unplug makes the firmware always ignore the very first
+	 * command. For such a case, provide some room for retries
+	 * instead of completly exiting the driver.

   Completely.

Thanks, both fixed in the next submission :-D

Regards,
Darwish