Re: [PATCH v2 03/14] btrfs: Fix function description format
From: David Sterba <hidden>
Date: 2021-01-21 16:27:52
On Wed, Jan 20, 2021 at 12:25:15PM +0200, Nikolay Borisov wrote:
quoted hunk ↗ jump to hunk
This fixes following W=1 warnings: fs/btrfs/file-item.c:27: warning: Cannot understand * @inode: the inode we want to update the disk_i_size for on line 27 - I thought it was a doc line fs/btrfs/file-item.c:65: warning: Cannot understand * @inode - the inode we're modifying on line 65 - I thought it was a doc line fs/btrfs/file-item.c:91: warning: Cannot understand * @inode - the inode we're modifying on line 91 - I thought it was a doc line Signed-off-by: Nikolay Borisov <redacted> --- fs/btrfs/file-item.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 6ccfc019ad90..fedb200c39ca 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c@@ -24,8 +24,10 @@ PAGE_SIZE)) /** - * @inode - the inode we want to update the disk_i_size for - * @new_i_size - the i_size we want to set to, 0 if we use i_size + * btrfs_inode_safe_disk_i_size_write
Have you not read https://lore.kernel.org/linux-btrfs/20210119224353.GU6430@twin.jikos.cz/ (local) ? Updating the whole comment is fine in one patch even if there are more types of changes, no point to do that in separate patches like for code.