On Thu, Jan 21, 2021 at 09:31:34AM +0200, Nikolay Borisov wrote:

On 20.01.21 г. 17:55 ч., Josef Bacik wrote:

quoted

On 1/20/21 5:25 AM, Nikolay Borisov wrote:

quoted

Now that the btrfs' codebase is clean of W=1 warning let's enable those
checks unconditionally for the entire fs/btrfs/ and its subdirectories.

Signed-off-by: Nikolay Borisov <redacted>

Once this is enabled I get

fs/btrfs/zoned.c: In function ‘btrfs_sb_log_location_bdev’:
fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used
[-Wunused-but-set-variable]
  491 |  u64 zone_size;
      |      ^~~~~~~~~

on misc-next.  Thanks,

I know, I intentionally haven't fixed it since:

a)  David might be intending to merge other patches which will utilize
this member

That's one possibility, but would show the warning until the zoned
patches get merged. I'd rather have a clean build once the W=1 build is
on.

I can insert a patch removing the variable, the zoned patches get still
rebased so that's fixable. Let me know if you want to send the patch as
it's from your series, or I can do that too.

b) It shows a genuine problem that this patchset has uncovered ( I even
mentioned this in the initial cover letter)

This should have been mentioned in the v2+ cover letter as well, along
with the version-to-version changelog.