Re: [PATCH 03/13] btrfs: Fix function description format
From: David Sterba <hidden>
Date: 2021-01-19 22:46:59
On Tue, Jan 19, 2021 at 02:26:39PM +0200, Nikolay Borisov wrote:
quoted hunk ↗ jump to hunk
This fixes following W=1 warnings: fs/btrfs/file-item.c:27: warning: Cannot understand * @inode: the inode we want to update the disk_i_size for on line 27 - I thought it was a doc line fs/btrfs/file-item.c:65: warning: Cannot understand * @inode - the inode we're modifying on line 65 - I thought it was a doc line fs/btrfs/file-item.c:91: warning: Cannot understand * @inode - the inode we're modifying on line 91 - I thought it was a doc line Signed-off-by: Nikolay Borisov <redacted> --- fs/btrfs/file-item.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-)diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 6ccfc019ad90..868b27e887b1 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c@@ -24,8 +24,10 @@ PAGE_SIZE)) /** - * @inode - the inode we want to update the disk_i_size for - * @new_i_size - the i_size we want to set to, 0 if we use i_size + * btrfs_inode_safe_disk_i_size_write
This is the part I don't like about kdoc but as we've talked about that, we can use a less strict formatting and follow this scheme: /** * Function summary description in one or two sentences. * * @param1: description * @param2: description * * Long description of the function. * * Return value semantics */ The kdoc checker is fine with the first line and validates the arguments, which is what we want. The validator can be enabled at build time as well by adding cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $< to our Makefile.
+ * + * @inode: the inode we want to update the disk_i_size for + * @new_i_size: the i_size we want to set to, 0 if we use i_size
Please align the descriptions