Thread (21 messages) 21 messages, 3 authors, 2021-01-19

Re: [PATCH 01/13] btrfs: Document modified paramater of add_extent_mapping

From: Josef Bacik <josef@toxicpanda.com>
Date: 2021-01-19 21:35:15

On 1/19/21 7:26 AM, Nikolay Borisov wrote:
quoted hunk ↗ jump to hunk
Fixes fs/btrfs/extent_map.c:399: warning: Function parameter or member
'modified' not described in 'add_extent_mapping'

Signed-off-by: Nikolay Borisov <redacted>
---
  fs/btrfs/extent_map.c | 2 ++
  1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index bd6229fb2b6f..aa1ff6f2ade9 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -388,6 +388,8 @@ static void extent_map_device_clear_bits(struct extent_map *em, unsigned bits)
   * add_extent_mapping - add new extent map to the extent tree
   * @tree:	tree to insert new map in
   * @em:		map to insert
+ * @modified:	bool indicating whether the given @em should be added to the
+ *	        modified list, which indicates the extent needs to be logged
   *
   * Insert @em into @tree or perform a simple forward/backward merge with
   * existing mappings.  The extent_map struct passed in will be inserted
You can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

to the series once you fix up those two spelling mistakes.  Thanks,

Josef
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help