Re: [patch V2 13/17] timers: Split [try_to_]del_timer[_sync]() to prepare for shutdown mode
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2022-11-23 18:46:22
Also in:
lkml, netdev
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2022-11-23 18:46:22
Also in:
lkml, netdev
On 11/23/2022 9:05 AM, Thomas Gleixner wrote:
On Tue, Nov 22 2022 at 15:04, Jacob Keller wrote:quoted
On 11/22/2022 9:45 AM, Thomas Gleixner wrote:quoted
+int try_to_del_timer_sync(struct timer_list *timer) +{ + return __try_to_del_timer_sync(timer); +} EXPORT_SYMBOL(try_to_del_timer_sync);Its a bit odd to me that some patches refactor and replace functions with new variants all under timer_* namespace, but then we've left some of them available without that. Any reasoning behind this? I guess "try_*" is pretty clear and unlikely to get stolen by other code..?Kinda. I renamed del_timer*() because that's the ones which we want to substitute with timer_shutdown*() where possible and reasonable. A larger timer namespace cleanup is subject to a follow up series. Thanks, tglx
Yep thats what I figured once I got to the end of the series. Thanks! Regards, Jake