Re: [patch V2 12/17] timers: Silently ignore timers with a NULL function

On Wed, Nov 23 2022 at 12:06, Anna-Maria Behnsen wrote:

On Tue, 22 Nov 2022, Thomas Gleixner wrote:

quoted

Add debug_assert_init() instead of the WARN_ON_ONCE(!timer->function)
checks so that debug objects can warn about non-initialized timers.

Could you expand this paragraph, so that is is not missleading when a
reader is not aware of the details of debug objects? Otherwise it seems to
the reader that debug objects will warn when timer->function == NULL.

  The warning of debug objects does not cover the original
  WARN_ON_ONCE(!timer->function). It warns when timer was not initialized
  using timer_setup[_on_stack]() or via DEFINE_TIMER().

Good point.