Re: [RFC PATCH 0/3] UART slave device bus
From: H. Nikolaus Schaller <hidden>
Date: 2016-08-19 01:03:45
Also in:
linux-serial, lkml
Am 18.08.2016 um 17:38 schrieb One Thousand Gnomes =
[off-list ref]:
=20quoted
quoted
Your changes also don't work because serial uart drivers are not =
obliged
quoted
quoted
to use any of the uart buffering helpers and particularly on the rx =
side
quoted
quoted
many do not do so and the performance hit would be too high. =20=20 The SoC I have, is using it.=20 The Linux kernel does generalised implementations. Yes it may work on your board but it doesn't work for everything.
It needs to work only on boards with a SoC UART. Not with a tty over USB or something else. This is the generalisation I see. Any SoC with uart_port driver support (and as far as I see many are).
It's the difference between doing it properly and hacking your board to work.
Agreed. But solving problems nobody really has is overengineering. Especially if the generalised implementation that is being discussed (tty_port) does not even solve the problem. Or only in a very clumsy and difficult way. In such a case a generalisation seems to be the wrong approach to me. And we should start to accept that we mix up different requirements and try a single solution for almost everyone we can imagine (which isn't bad initially, but can prohibit to find a solution at all) except = the real use case that is on the table. That is why I always come back to the practical problem to implement my driver and want to know how it can be done. BR, Nikolaus