Re: [PATCH 0/3] obexd fixes

On Mon, Jul 04, 2016 at 03:07:47PM +0300, Luiz Augusto von Dentz wrote:

Hi Don,

On Fri, Jul 1, 2016 at 12:01 AM, Don Zickus [off-list ref] wrote:

quoted

We started running some obexd tests to help mimic Fedora users passing info
from their phone to their laptop.  These tests uncovered some issues.

Let me know if I need to fix these patches or try something different.

Cheers,
Don

Don Zickus (3):
  obexd: Allow CreateFolder to create a directory
  obexd: Return dummy_data instead of int in phonebook-dummy
  obexd: Add a detailed failure message for exchanging business cards

 obexd/client/opp.c              |  2 +-
 obexd/plugins/ftp.c             |  2 ++
 obexd/plugins/phonebook-dummy.c | 11 +++++++----
 3 files changed, 10 insertions(+), 5 deletions(-)

--
1.8.3.1

Applied after fixing the following problems:

#36: FILE: obexd/plugins/phonebook-dummy.c:578:
+ dummy->id = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, create_cache, query,

obexd/plugins/phonebook-dummy.c:523:8: error: unused variable ‘ret’
[-Werror=unused-variable]
  guint ret;
        ^~~
obexd/plugins/phonebook-dummy.c:556:8: error: unused variable ‘ret’
[-Werror=unused-variable]
  guint ret;
        ^~~

Ive also fixed the author of the patches so we don't have to add in
the patch description.

Hi Luiz,

Side question,  Marek posted a patch back in April that didn't get any
attention.  It seems you are the committer for that code??  Could you look
and provide some feedback, if you have time?

http://article.gmane.org/gmane.linux.bluez.kernel/67420/match=

Thanks!

Cheers,
Don