Thread (9 messages) 9 messages, 3 authors, 2016-07-06

[PATCH 3/3] obexd: Add a detailed failure message for exchanging business cards

flat view
STALE3762d

From: Don Zickus <hidden>
Date: 2016-06-30 21:01:29
Subsystem: the rest · Maintainer: Linus Torvalds

When sending the ExchangeBusinessCards() command, the command returns
a failure.  It isn't clear what that failure is.  Upon looking through
the code, it is obvious the funciton is not implemented.

This patch just adds an extra detail message 'Not Implemented' to make
the failure a little more clear about what the problem is.
---
 obexd/client/opp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/obexd/client/opp.c b/obexd/client/opp.c
index 3c2801a..0e063dd 100644
--- a/obexd/client/opp.c
+++ b/obexd/client/opp.c
@@ -117,7 +117,7 @@ fail:
 static DBusMessage *opp_exchange_business_cards(DBusConnection *connection,
 					DBusMessage *message, void *user_data)
 {
-	return g_dbus_create_error(message, ERROR_INTERFACE ".Failed", NULL);
+	return g_dbus_create_error(message, ERROR_INTERFACE ".Failed", "Not Implemented");
 }
 
 static const GDBusMethodTable opp_methods[] = {
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help