Re: [KERNEL PATCH] HID: Add support for Sony BD Remote
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-09-14 10:42:48
Hi David, On Fri, Sep 14, 2012 at 6:04 AM, David Dillow [off-list ref] wrote:
We also gain support for the Logitech Harmony Adapter for PS3. Signed-off-by: David Dillow <dave@thedillows.org> -- drivers/hid/Kconfig | 7 + drivers/hid/Makefile | 1 + drivers/hid/hid-core.c | 2 + drivers/hid/hid-ps3remote.c | 325 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 335 insertions(+), 0 deletions(-) On Thu, 2012-09-13 at 00:36 +0200, Antonio Ospite wrote: On Wed, 12 Sep 2012 22:26:04 +0200 David Herrmann wrote:quoted
quoted
So if the devices only need some short setup-command during initialization and then they send HID reports whenever a button is pressed, then everything should be very easy to get working. Even auto-reconnect and 10min idle-disconnect are _very_ easy to get working in the kernel with the current HID infrastructure.I too will take a look during the week-end about writing a kernel driver, if it's not that much of an effort I might take the project (no promises yet). I have a PS3 BD remote Bastien donated.Here's a first pass at a kernel driver to support the BD remote and Harmony PS adapter. I've tested it on Fedora 16 with single keypresses only, as I cannot send multiple simultaneous keypresses with the Harmony. This patch is against kernel.org's bluetooth.git as of an hour ago, but should apply to other versions without much fuss.
Great that you are looking into it.
Antonio, if you could test this with the real remote you have, I'd be very appreciative. David, could you point me at the controls for the 10min idle-disconnect?
I suppose we can just continue using input.conf:IdleTimeout (which passed via ioctl in the struct hidp_connadd_req.idle_to) or do you think this would be useful for other transports, at least for USB it does not make much sense since the cable will stay connected.
auto-connect and idle-disconnect seem to be working on my Fedora 16 box, though it looks like the Harmony adapter is initiating the disconnect -- this is likely an area for improvement with the Sony remote.
Btw, it would probably be a good to add a proper defines for 0x0306 e.g. USB_DEVICE_ID_SONY_PS3_REMOTE and USB_DEVICE_ID_LOGITECH_HARMONY_ADAPTER -- Luiz Augusto von Dentz