Re: [KERNEL PATCH] HID: Add support for Sony BD Remote
From: David Dillow <dave@thedillows.org>
Date: 2012-09-14 12:17:24
On Fri, 2012-09-14 at 13:42 +0300, Luiz Augusto von Dentz wrote:
Hi David, On Fri, Sep 14, 2012 at 6:04 AM, David Dillow [off-list ref] wrote:quoted
Antonio, if you could test this with the real remote you have, I'd be very appreciative. David, could you point me at the controls for the 10min idle-disconnect?I suppose we can just continue using input.conf:IdleTimeout (which passed via ioctl in the struct hidp_connadd_req.idle_to) or do you think this would be useful for other transports, at least for USB it does not make much sense since the cable will stay connected.
I'm agreed that it doesn't make much sense for USB. I would like to find a way to keep the adapter running -- it seems I don't get the first key press that the adapter woke up for. This would need to be optional, as I see this draining the batteries on the real remote, but my adapter is hardwired and it'd be nice to avoid the initial delay/lost press. Of course solving the initial press would be handy for everyone, assuming it isn't a Harmony-only issue.
quoted
auto-connect and idle-disconnect seem to be working on my Fedora 16 box, though it looks like the Harmony adapter is initiating the disconnect -- this is likely an area for improvement with the Sony remote.Btw, it would probably be a good to add a proper defines for 0x0306 e.g. USB_DEVICE_ID_SONY_PS3_REMOTE and USB_DEVICE_ID_LOGITECH_HARMONY_ADAPTER
Heh, I thought you might say that. I personally prefer the numbers ala the current style for PCI(e) drivers -- and took the prior existence of the numbers-only entries as permission -- but I'll defer to the wishes of the subsystem. Thanks, Dave