Thread (22 messages) flat view 22 messages, 3 authors, 2012-03-19

Re: [PATCH obexd v0 04/11] client: fix progress report before field update

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-03-19 13:03:12

Hi Mikel,

On Mon, Mar 12, 2012 at 10:32 AM, Mikel Astiz [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Mikel Astiz <redacted>

The progress report in put_xfer_progress was done before the
corresponding field was updated.
---
 client/transfer.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/transfer.c b/client/transfer.c
index f2a153c..bc896f8 100644
--- a/client/transfer.c
+++ b/client/transfer.c
@@ -493,10 +493,10 @@ static gssize put_xfer_progress(void *buf, gsize len, gpointer user_data)
       if (size <= 0)
               return size;

-       transfer_notify_progress(transfer);
-
       transfer->transferred += size;

+       transfer_notify_progress(transfer);
+
       return size;
 }

--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ack.

-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help