Re: [PATCH obexd v0 05/11] client: transfer api merges put and get
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2012-03-19 17:58:33
Hi Mikel, On Mon, Mar 19, 2012 at 11:55 AM, Mikel Astiz [off-list ref] wrote:
The main problem with this is that, when you want both file-based and memory-based transfers (see patch v0 07/11), you would have 4 possible combinations.
I guess we can always use temporary files, anyway if the filename is not set than it means the transfer will be buffered.
Another (less relevant) reason is that some client code could be interested in checking this field. For example the agent needs to know that currently. I would even propose we make this field public in D-Bus in the future, so it would be weird that you have less information in the internal api.
Well usually the session should know what direction it is since it is queuing them, we can even have a field inside pending_request for that although the callback could be use for that purpose. As for the internal API, transfer should also know what direction it is, right now what is missing is knowing before it gets started what the direction would be but this can be solved with register_get/register_put. Actually if we have a transfer_start we can make transfer_put and transfer_get to internally call transfer_registration, of course the parameters would have to be changed as well. -- Luiz Augusto von Dentz