Re: [PATCH v2] Bluetooth: Remove usage of __cancel_delayed_work()
From: Ulisses Furquim <hidden>
Date: 2012-01-21 19:35:52
Great. But Johan please wait to apply. I'll send a new one with another change to prevent a crash. On Saturday, January 21, 2012, Marcel Holtmann [off-list ref] wrote:
Hi Ulisses,quoted
__cancel_delayed_work() is being used in some paths where we cannot sleep waiting for the delayed work to finish. However, that function might return while the timer is running and the work will be queued again. Replace the calls with safer cancel_delayed_work() version which spins until the timer handler finishes in other CPUs and cancels the delayed work. Signed-off-by: Ulisses Furquim <redacted> --- v2 - rebased against newer bluetooth-next include/net/bluetooth/l2cap.h | 4 ++-- net/bluetooth/l2cap_core.c | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-)looks fine to me. Acked-by: Marcel Holtmann <marcel@holtmann.org> Regards Marcel
-- Ulisses Furquim ProFUSION embedded systems http://profusion.mobi Mobile: +55 19 9250 0942 Skype: ulissesffs