Thread (4 messages) flat view 4 messages, 2 authors, 2012-01-21

Re: [PATCH v2] Bluetooth: Remove usage of __cancel_delayed_work()

From: Ulisses Furquim <hidden>
Date: 2012-01-21 19:42:08

Hi Marcel,

On Sat, Jan 21, 2012 at 2:46 PM, Marcel Holtmann [off-list ref] wrot=
e:
Hi Ulisses,
quoted
__cancel_delayed_work() is being used in some paths where we cannot
sleep waiting for the delayed work to finish. However, that function
might return while the timer is running and the work will be queued
again. Replace the calls with safer cancel_delayed_work() version
which spins until the timer handler finishes in other CPUs and
cancels the delayed work.

Signed-off-by: Ulisses Furquim <redacted>
---

v2 - rebased against newer bluetooth-next

=A0include/net/bluetooth/l2cap.h | =A0 =A04 ++--
=A0net/bluetooth/l2cap_core.c =A0 =A0| =A0 10 +++++-----
=A02 files changed, 7 insertions(+), 7 deletions(-)
looks fine to me.

Acked-by: Marcel Holtmann <marcel@holtmann.org>
Great. However, Johan please wait to apply. I'll send another version
with 2 patches including a fix for a possible crash.

Regards,

--
Ulisses Furquim
ProFUSION embedded systems
http://profusion.mobi
Mobile: +55 19 9250 0942
Skype: ulissesffs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help