Re: [PATCH BlueZ] Fix memory leak when loading keys
From: Anderson Lizardo <hidden>
Date: 2012-01-24 10:40:03
Hi Vinicius, On Mon, Jan 23, 2012 at 8:21 PM, Vinicius Costa Gomes [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -3570,7 +3571,16 @@ static int hciops_load_keys(int index, GSList *keys, gboolean debug_keys)if (dev->keys != NULL) return -EEXIST; - dev->keys = keys; + for (l = keys; l; l = l->next) { + struct link_key_info *orig, *dup; + + orig = l->data; + + dup = g_memdup(orig, sizeof(*orig)); + + dev->keys = g_slist_prepend(dev->keys, dup); + } +
No need to cleanup dev->keys first? Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil