Thread (12 messages) read the whole thread 12 messages, 3 authors, 2011-12-09

Re: [PATCH 1/6] Implement SetProperty D-Bus method

From: Johan Hedberg <hidden>
Date: 2011-12-07 14:58:51

Hi Santiago,

On Tue, Nov 22, 2011, Santiago Carot-Nemesio wrote:
---
 thermometer/thermometer.c |  118 +++++++++++++++++++++++++++++++++++++-------
 1 files changed, 99 insertions(+), 19 deletions(-)
Is this patch set still valid? If so, could you resend it with proper
commit messages. "Implement SetProperty D-Bus method" is much too
generic. It'd be nice if you could start using the convention we've
tried to adopt where we add context dependent prefixes to the message
summaries. In this case "thermometer: Add SetProperty D-Bus method"
would have already given enough of context to not have to look at the
patch content to know what it does.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help