Re: [PATCH 1/6] Implement SetProperty D-Bus method

Hi Johan,

2011/12/7 Johan Hedberg [off-list ref]:

Hi Santiago,

On Tue, Nov 22, 2011, Santiago Carot-Nemesio wrote:

quoted

---
 thermometer/thermometer.c |  118 +++++++++++++++++++++++++++++++++++++-------
 1 files changed, 99 insertions(+), 19 deletions(-)

Is this patch set still valid? If so, could you resend it with proper
commit messages. "Implement SetProperty D-Bus method" is much too
generic. It'd be nice if you could start using the convention we've
tried to adopt where we add context dependent prefixes to the message
summaries. In this case "thermometer: Add SetProperty D-Bus method"
would have already given enough of context to not have to look at the
patch content to know what it does.

Discard this set of patches for now, I'll prepare a new set after
fixing the magic number issue in GATT.
Regards.