Re: [PATCH v5 13/15] Bluetooth: LE scan infra-structure

Hi Andre,

* Andre Guedes [off-list ref] [2011-10-06 17:31:06 -0300]:

Hi Gustavo,

On Oct 6, 2011, at 4:06 PM, Gustavo Padovan wrote:

quoted

Hi Andre,

* Andre Guedes [off-list ref] [2011-10-05 20:20:45 -0300]:

quoted

This patch adds to hci_core the infra-structure to carry out the
LE scan. Functions were created to init the LE scan and cancel
an ongoing scanning (hci_do_le_scan and hci_cancel_le_scan).

Also, the HCI_LE_SCAN flag was created to inform if the controller
is performing LE scan. The flag is set/cleared when the controller
starts/stops scanning.

Signed-off-by: Andre Guedes <redacted>
---
include/net/bluetooth/hci.h      |    2 +
include/net/bluetooth/hci_core.h |    5 +++
net/bluetooth/hci_core.c         |   69 ++++++++++++++++++++++++++++++++++++++
net/bluetooth/hci_event.c        |    4 ++
4 files changed, 80 insertions(+), 0 deletions(-)

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 11537b8..7520544 100644
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h

@@ -86,6 +86,8 @@ enum {

	HCI_DEBUG_KEYS,

	HCI_RESET,
+
+	HCI_LE_SCAN,

I remember that Marcel commented against this here. Let's hide this
internally.

If I got it right, Marcel agreed in keeping this flag here, but we
won't export it to userspace now (we'll keep it hidden internally).

hdev->flags is exported to userspace, it is not internal. We need to create
other place in struct hci_dev to keep this info. See some of Marcel's reply on
this.

	Gustavo