Re: [PATCH v5 13/15] Bluetooth: LE scan infra-structure

Hi Gustavo,

On Oct 7, 2011, at 5:12 PM, Gustavo Padovan wrote:

Hi Andre,
=20
* Andre Guedes [off-list ref] [2011-10-06 17:31:06 =

-0300]:

=20

quoted

Hi Gustavo,
=20
On Oct 6, 2011, at 4:06 PM, Gustavo Padovan wrote:
=20

quoted

Hi Andre,
=20
* Andre Guedes [off-list ref] [2011-10-05 20:20:45 =

-0300]:

quoted

quoted

=20

quoted

This patch adds to hci_core the infra-structure to carry out the
LE scan. Functions were created to init the LE scan and cancel
an ongoing scanning (hci_do_le_scan and hci_cancel_le_scan).
=20
Also, the HCI_LE_SCAN flag was created to inform if the controller
is performing LE scan. The flag is set/cleared when the controller
starts/stops scanning.
=20
Signed-off-by: Andre Guedes <redacted>
---
include/net/bluetooth/hci.h      |    2 +
include/net/bluetooth/hci_core.h |    5 +++
net/bluetooth/hci_core.c         |   69 =

++++++++++++++++++++++++++++++++++++++

quoted

quoted

quoted

net/bluetooth/hci_event.c        |    4 ++
4 files changed, 80 insertions(+), 0 deletions(-)
=20

diff --git a/include/net/bluetooth/hci.h =

b/include/net/bluetooth/hci.h

quoted

quoted

quoted

index 11537b8..7520544 100644

--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h

@@ -86,6 +86,8 @@ enum {

	HCI_DEBUG_KEYS,
=20
	HCI_RESET,
+
+	HCI_LE_SCAN,

=20
I remember that Marcel commented against this here. Let's hide this
internally.

=20
If I got it right, Marcel agreed in keeping this flag here, but we
won't export it to userspace now (we'll keep it hidden internally).

=20
hdev->flags is exported to userspace, it is not internal. We need to =

create

other place in struct hci_dev to keep this info. See some of Marcel's =

reply on

this.

When I said "export to userspace" I meant to add this flag to userspace
header (lib/hci.h). Even though hdev->flags is exported to userspace,
if the flag is not defined at that header the userspace cannot decode it
properly. This way the flag is hidden internally in kernel.

Marcel, could you clarify this? Are you fine with we keep this =
HCI_LE_SCAN
in hdev->flags?

BR,

Andre=