Re: [PATCH v2 09/16] Bluetooth: Prepare for full support discovery procedures

Hi Marcel,

On Aug 10, 2011, at 9:24 PM, Marcel Holtmann wrote:

quoted

quoted

I don't think this is a good idea. You keep forgetting if you actually
have LE switched on or not.

I think we should keep it like this and just keep a global hci_dev  
state
which discovery procedure to use. Depending on if the device is just
really LE-Only, it is dual-stack, but LE got switched off (we will  
need
this eventually for testing) or it is just only BR/EDR.

I agree. What really matters for the discovery procedure is the
operation mode not the device type. The term "device type" was
misused here.

About the global hci_dev state, IMO we may not need it. By looking
at the controller's LMP features we are able to infer what is the
controller's operation mode.

you need to look at the extended features page 1, but yes, if you have
that available, the it might be as simple as have the global state.

It really depends on how often you have to check. Maybe it is worth to
just have a simple operation mode variable compared to always have to
access multiple bits in the features array. Depends on how often you
need to use it.

Yes, sure. Since we don't check these bits so often, we can check the
LMP features instead of having the global variable. This way we keep
it simple.

BR,

Andre.