Thread (33 messages) flat view 33 messages, 3 authors, 2011-09-09

Re: [PATCH v2 11/16] Bluetooth: Add 'eir_len' param to mgmt_device_found()

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2011-08-10 15:17:44

Hi Anderson,
quoted
quoted
This patch adds a new parameter to mgmt_device_found() to inform
the length of 'eir' pointer.

EIR data from LE advertising report event doesn't have a fixed length
as EIR data from extended inquiry result event does. We needed to
change mgmt_device_found() so it copies 'eir_len' bytes instead of
HCI_MAX_EIR_LENGTH.
what is the max EIR length for LE? Is it more than with BR/EDR. Or is it
just variable length?
From page 1735:

"The data consists of a significant part and a non-significant part.
[...] The non-significant part extends the Advertising and Scan
Response data to 31 octets and shall contain all-zero octets."

So actually it is not variable length, it has 31 octets, with the
non-significant part zero padded. BR/EDR EIR, on the other hand is 240
bytes (with zero padding for non-significant part as well)
do we have a deep impact (memory wise) if we always pad this up to 240.
If we do, then we might wanna be smarter here anyway.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help