Re: [PATCH] Expose wacom pen tablet battery and ac thru power_supply class

On Wed, 10 Mar 2010, Przemo Firszt wrote:

quoted

Anyway, you'll have to sort out the new dependency on CONFIG_POWER_SUPPLY 
somehow (compiling the battery code out from the driver if 
CONFIG_POWER_SUPPLY is unset, or selecting it directly from Kconfig).

Thanks for checking the patch.
See attached updated version - is it OK?
Does it make sense to add a line to Kconfig to explain that
CONFIG_POWER_SUPPLY/CONFIG_POWER_SUPPLY_MODULE is required to enable
monitoring battery/ac state?

Either that, or introducing separate CONFIG sub-option for the Wacom 
driver might be reasonable option as well.

Otherwise the patch looks good.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.