Re: [PATCH] Expose wacom pen tablet battery and ac thru power_supply class

On Mon, 15 Mar 2010, Przemo Firszt wrote:

quoted

quoted

Does it make sense to add a line to Kconfig to explain that
CONFIG_POWER_SUPPLY/CONFIG_POWER_SUPPLY_MODULE is required to enable
monitoring battery/ac state?

Either that, or introducing separate CONFIG sub-option for the Wacom 
driver might be reasonable option as well.

Hi Jiri,
Thanks for help - next time I'll know how to do it :-)
I went the CONFIG sub-option way - see attached.

I have applied it, thanks.

One question still though ..

+       case POWER_SUPPLY_PROP_CAPACITY:
+               /* show 100% battery capacity when charging */
+               if (power_state == 0)
+                       val->intval = 100;
+               else
+                       val->intval = power_state;
+               break;

Why is it not possible to show the actual percentage in the charging state 
as well?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.